tools/docker: add solana localnet #11574
Conversation
jmank88
force-pushed
the
tools-solana
branch
from
67f98bf to
7579def
Compare
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jmank88
changed the title
|
SonarQube Quality Gate
|
| # - CL_SOLANA_CMD=chainlink-solana | ||
| # - CL_MEDIAN_CMD=chainlink-median |
There was a problem hiding this comment.
They are disabled by default. This is leftover after I tried to enable them - but IIRC this is rigged up to build a different Dockerfile that doesn't have them yet. I will remove this or add them to that file.
There was a problem hiding this comment.
Sorry, "I will remove this or add them to that file." - has this been already done?
There was a problem hiding this comment.
No this has become stale, but I thought it might be a good reference for how things fit together in this sub dir.
There was a problem hiding this comment.
Sorry, is it clear what happens if you uncomment these lines? Is expected behavior to build a different docker image and enable these plugins? If yes, could you please test it and describe this behavior in the comment above.
There was a problem hiding this comment.
These lines are meant to enable LOOP Plugins. I expected it to "just work", because they are built in to the official docker image now (just disabled by default). However, something broken and I'm not sure what, because my explanation in the first comment seems wrong - the regular docker images are used 🤔
We should fix it, but it is orthogonal to running Solana, so it could be left out of this PR.
| RUN tar jxf solana-release-x86_64-unknown-linux-gnu.tar.bz2 | ||
| ENV PATH=/solana/solana-release/bin:$PATH | ||
|
|
||
| ENTRYPOINT [ "solana-test-validator" ] |
There was a problem hiding this comment.
just curious, would you also want prefunding the CL node?
you should be able to do that with the solana airdop command
jmank88
force-pushed
the
tools-solana
branch
from
7579def to
50d5881
Compare
|
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
| @@ -4,7 +4,7 @@ set -ex | |||
| export DOCKER_BUILDKIT=1 | |||
| export COMPOSE_DOCKER_CLI_BUILD=1 | |||
|
|
|||
| base_files="-f docker-compose.yaml -f docker-compose.postgres.yaml" | |||
| base_files="-f docker-compose.yaml -f docker-compose.postgres.yaml -f docker-compose.solana.yaml" | |||
There was a problem hiding this comment.
We already have a custom logic based on $GETH_MODE, would it make sense to have the same for solana?
There was a problem hiding this comment.
It looks like $GETH_MODE toggle between go-ethereum vs. parity clients. AFAIK we don't have client variety on Solana, so we don't need an equivalent toggle.
There was a problem hiding this comment.
Sorry, I meant what happens if we want to run the node without Solana at all. Is the configuration supposed to be flexible?
There was a problem hiding this comment.
We could make it flexible. This setup predates multi-chain and non-evm support, and hasn't been updated with those in mind until now, so this is an open question.
There was a problem hiding this comment.
At the time, I just wanted a simpler way to test LOOP Plugins like Solana, without running CI integration tests.
There was a problem hiding this comment.
When running solana docker I get the following error "rosetta error: failed to open elf at /lib64/ld-linux-x86-64.so.2". I am using my Macbook for testing - is there an agreement that the docker files should be cross-platform? (I think we need to add something along the lines of https://stackoverflow.com/questions/71040681/qemu-x86-64-could-not-open-lib64-ld-linux-x86-64-so-2-no-such-file-or-direc to fix the issue)
There was a problem hiding this comment.
Yes, if we can make it cross-platform then we should.
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
No description provided.